]> granicus.if.org Git - clang/commitdiff
clang-format: [ObjC] Fix using selector names as macro arguments.
authorDaniel Jasper <djasper@google.com>
Mon, 20 Oct 2014 12:01:45 +0000 (12:01 +0000)
committerDaniel Jasper <djasper@google.com>
Mon, 20 Oct 2014 12:01:45 +0000 (12:01 +0000)
Before:
  [self aaaaa:MACRO(a, b :, c :)];

After:
  [self aaaaa:MACRO(a, b:, c:)];

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@220197 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTest.cpp

index ad14aab7cd9bbf7eb0676d1f355df64bf8b40672..33627e5a95a150dc7f900c05db1b47015fdc6cb4 100644 (file)
@@ -413,6 +413,11 @@ private:
       } else if (Contexts.size() == 1 &&
                  !Line.First->isOneOf(tok::kw_enum, tok::kw_case)) {
         Tok->Type = TT_InheritanceColon;
+      } else if (Tok->Previous->is(tok::identifier) && Tok->Next &&
+                 Tok->Next->isOneOf(tok::r_paren, tok::comma)) {
+        // This handles a special macro in ObjC code where selectors including
+        // the colon are passed as macro arguments.
+        Tok->Type = TT_ObjCMethodExpr;
       } else if (Contexts.back().ContextKind == tok::l_paren) {
         Tok->Type = TT_InlineASMColon;
       }
index 6961ab59c13d619fcf300e26356f1d6c0004f21f..a16ee2cb2f5b85f5913fa50542ac06adf1048129 100644 (file)
@@ -6539,6 +6539,7 @@ TEST_F(FormatTest, FormatObjCMethodExpr) {
   verifyFormat("return in[42];");
   verifyFormat("for (id foo in [self getStuffFor:bla]) {\n"
                "}");
+  verifyFormat("[self aaaaa:MACRO(a, b:, c:)];");
 
   verifyFormat("[self stuffWithInt:(4 + 2) float:4.5];");
   verifyFormat("[self stuffWithInt:a ? b : c float:4.5];");