]> granicus.if.org Git - clang/commitdiff
Fix a trivial oversight with apple-kext static local destructors
authorJohn McCall <rjmccall@apple.com>
Fri, 13 Apr 2012 02:53:27 +0000 (02:53 +0000)
committerJohn McCall <rjmccall@apple.com>
Fri, 13 Apr 2012 02:53:27 +0000 (02:53 +0000)
and add a test case.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@154653 91177308-0d34-0410-b5e6-96231b3b80d8

lib/CodeGen/CGDeclCXX.cpp
test/CodeGenCXX/apple-kext.cpp [new file with mode: 0644]

index 99d50312b524635df0d7c192feadf8e135f6cd31..10f0b83e40535342150d300d771dfc72180c7b92 100644 (file)
@@ -244,6 +244,7 @@ void CodeGenFunction::EmitCXXGlobalDtorRegistration(llvm::Constant *dtor,
   if (CGM.getContext().getLangOpts().AppleKext) {
     // Generate a global destructor entry.
     CGM.AddCXXDtorEntry(dtor, addr);
+    return;
   }
 
   // Otherwise, we just use atexit.
diff --git a/test/CodeGenCXX/apple-kext.cpp b/test/CodeGenCXX/apple-kext.cpp
new file mode 100644 (file)
index 0000000..03506a8
--- /dev/null
@@ -0,0 +1,22 @@
+// RUN: %clang_cc1 -triple x86_64-apple-darwin10 -fno-use-cxa-atexit -fapple-kext -emit-llvm -o - %s | FileCheck %s
+
+// CHECK: @_ZN5test01aE = global [[A:%.*]] zeroinitializer
+// CHECK: @llvm.global_ctors = appending global {{.*}} { i32 65535, void ()* [[CTOR0:@.*]] }
+// CHECK: @llvm.global_dtors = appending global {{.*}} { i32 65535, void ()* [[DTOR0:@.*]] }
+
+// rdar://11241230
+namespace test0 {
+  struct A { A(); ~A(); };
+  A a;
+}
+// CHECK:    define internal void [[CTOR0_:@.*]]()
+// CHECK:      call void @_ZN5test01AC1Ev([[A]]* @_ZN5test01aE)
+// CHECK-NEXT: ret void
+
+// CHECK:    define internal void [[CTOR0]]()
+// CHECK:      call void [[CTOR0_]]()
+// CHECK-NEXT: ret void
+
+// CHECK:    define internal void [[DTOR0]]()
+// CHECK:      call void @_ZN5test01AD1Ev([[A]]* @_ZN5test01aE)
+// CHECK-NEXT: ret void