silence -Wreturn-type warnings

These codepaths would generate warnings with GCC on linux even though the switch
was covered.  Add llvm_unreachable markers to indicate that the switch should be
covered.  NFC.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@260865 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/lib/Index/IndexSymbol.cpp b/lib/Index/IndexSymbol.cpp
index bf3bfd1b95b3a1eaff71efd69d4442ea07d141fd..95ae9776826ffaa15aa323ca534313c8968e3283 100644 (file)
--- a/lib/Index/IndexSymbol.cpp
+++ b/lib/Index/IndexSymbol.cpp
@@ -266,6 +266,7 @@ StringRef index::getSymbolKindString(SymbolKind K) {
   case SymbolKind::CXXTypeAlias: return "type-alias";
   case SymbolKind::CXXInterface: return "c++-__interface";
   }
+  llvm_unreachable("invalid symbol kind");
 }
 
 StringRef index::getTemplateKindStr(SymbolCXXTemplateKind TK) {
@@ -275,6 +276,7 @@ StringRef index::getTemplateKindStr(SymbolCXXTemplateKind TK) {
   case SymbolCXXTemplateKind::TemplatePartialSpecialization : return "TPS";
   case SymbolCXXTemplateKind::TemplateSpecialization: return "TS";
   }
+  llvm_unreachable("invalid template kind");
 }
 
 StringRef index::getSymbolLanguageString(SymbolLanguage K) {
@@ -283,4 +285,5 @@ StringRef index::getSymbolLanguageString(SymbolLanguage K) {
   case SymbolLanguage::ObjC: return "ObjC";
   case SymbolLanguage::CXX: return "C++";
   }
+  llvm_unreachable("invalid symbol language kind");
 }

diff --git a/lib/Index/IndexingContext.cpp b/lib/Index/IndexingContext.cpp
index 91fbbfb268432cd8faeaca3b130150460955b422..9ac22f85e1de98327ab09f898b23ce74d0ef4a5f 100644 (file)
--- a/lib/Index/IndexingContext.cpp
+++ b/lib/Index/IndexingContext.cpp
@@ -135,6 +135,7 @@ bool IndexingContext::isTemplateImplicitInstantiation(const Decl *D) {
     case TSK_ExplicitInstantiationDefinition:
       return true;
   }
+  llvm_unreachable("invalid TemplateSpecializationKind");
 }
 
 bool IndexingContext::shouldIgnoreIfImplicit(const Decl *D) {

diff --git a/tools/libclang/CXIndexDataConsumer.cpp b/tools/libclang/CXIndexDataConsumer.cpp
index f6f8e306794baa3224c82f0f8995abaa17485e35..322725ec654d4b79322701835c6a3e44fa233844 100644 (file)
--- a/tools/libclang/CXIndexDataConsumer.cpp
+++ b/tools/libclang/CXIndexDataConsumer.cpp
@@ -1263,6 +1263,7 @@ static CXIdxEntityKind getEntityKindFromSymbolKind(SymbolKind K) {
   case SymbolKind::CXXTypeAlias: return CXIdxEntity_CXXTypeAlias;
   case SymbolKind::CXXInterface: return CXIdxEntity_CXXInterface;
   }
+  llvm_unreachable("invalid symbol kind");
 }
 
 static CXIdxEntityCXXTemplateKind
@@ -1275,6 +1276,7 @@ getEntityKindFromSymbolCXXTemplateKind(SymbolCXXTemplateKind K) {
   case SymbolCXXTemplateKind::TemplateSpecialization:
     return CXIdxEntity_TemplateSpecialization;
   }
+  llvm_unreachable("invalid template kind");
 }
 
 static CXIdxEntityLanguage getEntityLangFromSymbolLang(SymbolLanguage L) {
@@ -1283,4 +1285,5 @@ static CXIdxEntityLanguage getEntityLangFromSymbolLang(SymbolLanguage L) {
   case SymbolLanguage::ObjC: return CXIdxEntityLang_ObjC;
   case SymbolLanguage::CXX: return CXIdxEntityLang_CXX;
   }
+  llvm_unreachable("invalid symbol language");
 }