Fix crash in balancer-manager.

This was due to an incomplete refactoring in
r771940 (switching balancer->workers to an
array of pointers).

It's likely that other balancer functionality
was broken too.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@891230 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/CHANGES b/CHANGES
index aa16383327377ebba7a0e90b3632dc2d3b7a6e61..7acb0385423934b67910aded6cfdd91a7f21db0e 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -2,6 +2,8 @@
 
 Changes with Apache 2.3.5
 
+  *) mod_proxy_balancer: Fix crash in balancer-manager. [Rainer Jung]
+
   *) mod_headers: Ensure that changes to the main request remain valid when
      the subrequest is destroyed. PR 48359 [Nick Kew, Ruediger Pluem]
 

diff --git a/modules/proxy/mod_proxy_balancer.c b/modules/proxy/mod_proxy_balancer.c
index cc918ac2fd2b59382a6880e49834e5e334e0b1be..03ed92288b2c57fddf3959e879ef3470c76a32ec 100644 (file)
--- a/modules/proxy/mod_proxy_balancer.c
+++ b/modules/proxy/mod_proxy_balancer.c
@@ -197,12 +197,14 @@ static proxy_worker *find_route_worker(proxy_balancer *balancer,
     int checking_standby;
     int checked_standby;
     
+    proxy_worker **workers;
     proxy_worker *worker;
 
     checking_standby = checked_standby = 0;
     while (!checked_standby) {
-        worker = (proxy_worker *)balancer->workers->elts;
-        for (i = 0; i < balancer->workers->nelts; i++, worker++) {
+        workers = (proxy_worker **)balancer->workers->elts;
+        for (i = 0; i < balancer->workers->nelts; i++, workers++) {
+            worker = *workers;
             if ( (checking_standby ? !PROXY_WORKER_IS_STANDBY(worker) : PROXY_WORKER_IS_STANDBY(worker)) )
                 continue;
             if (*(worker->s->route) && strcmp(worker->s->route, route) == 0) {
@@ -470,13 +472,13 @@ static int proxy_balancer_pre_request(proxy_worker **worker,
     runtime = find_session_route(*balancer, r, &route, &sticky, url);
     if (runtime) {
         int i, total_factor = 0;
-        proxy_worker *workers;
+        proxy_worker **workers;
         /* We have a sticky load balancer
          * Update the workers status
          * so that even session routes get
          * into account.
          */
-        workers = (proxy_worker *)(*balancer)->workers->elts;
+        workers = (proxy_worker **)(*balancer)->workers->elts;
         for (i = 0; i < (*balancer)->workers->nelts; i++) {
             /* Take into calculation only the workers that are
              * not in error state or not disabled.
@@ -484,9 +486,9 @@ static int proxy_balancer_pre_request(proxy_worker **worker,
              * TODO: Abstract the below, since this is dependent
              *       on the LB implementation
              */
-            if (PROXY_WORKER_IS_USABLE(workers)) {
-                workers->s->lbstatus += workers->s->lbfactor;
-                total_factor += workers->s->lbfactor;
+            if (PROXY_WORKER_IS_USABLE(*workers)) {
+                (*workers)->s->lbstatus += (*workers)->s->lbfactor;
+                total_factor += (*workers)->s->lbfactor;
             }
             workers++;
         }
@@ -497,15 +499,15 @@ static int proxy_balancer_pre_request(proxy_worker **worker,
     }
     else if (route && (*balancer)->sticky_force) {
         int i, member_of = 0;
-        proxy_worker *workers;
+        proxy_worker **workers;
         /*
          * We have a route provided that doesn't match the
          * balancer name. See if the provider route is the
          * member of the same balancer in which case return 503
          */
-        workers = (proxy_worker *)(*balancer)->workers->elts;
+        workers = (proxy_worker **)(*balancer)->workers->elts;
         for (i = 0; i < (*balancer)->workers->nelts; i++) {
-            if (*(workers->s->route) && strcmp(workers->s->route, route) == 0) {
+            if (*((*workers)->s->route) && strcmp((*workers)->s->route, route) == 0) {
                 member_of = 1;
                 break;
             }
@@ -630,21 +632,21 @@ static int proxy_balancer_post_request(proxy_worker *worker,
 static void recalc_factors(proxy_balancer *balancer)
 {
     int i;
-    proxy_worker *workers;
+    proxy_worker **workers;
 
 
     /* Recalculate lbfactors */
-    workers = (proxy_worker *)balancer->workers->elts;
+    workers = (proxy_worker **)balancer->workers->elts;
     /* Special case if there is only one worker it's
      * load factor will always be 1
      */
     if (balancer->workers->nelts == 1) {
-        workers->s->lbstatus = workers->s->lbfactor = 1;
+        (*workers)->s->lbstatus = (*workers)->s->lbfactor = 1;
         return;
     }
     for (i = 0; i < balancer->workers->nelts; i++) {
         /* Update the status entries */
-        workers[i].s->lbstatus = workers[i].s->lbfactor;
+        workers[i]->s->lbstatus = workers[i]->s->lbfactor;
     }
 }
 
@@ -682,6 +684,7 @@ static int balancer_handler(request_rec *r)
         ap_get_module_config(sconf, &proxy_module);
     proxy_balancer *balancer, *bsel = NULL;
     proxy_worker *worker, *wsel = NULL;
+    proxy_worker **workers = NULL;
     apr_table_t *params = apr_table_make(r->pool, 10);
     int access_status;
     int i, n;
@@ -731,13 +734,14 @@ static int balancer_handler(request_rec *r)
 
         ws = ap_proxy_get_worker(r->pool, conf, name);
         if (bsel && ws) {
-            worker = (proxy_worker *)bsel->workers->elts;
+            workers = (proxy_worker **)bsel->workers->elts;
             for (n = 0; n < bsel->workers->nelts; n++) {
+                worker = *workers;
                 if (strcasecmp(worker->name, ws->name) == 0) {
                     wsel = worker;
                     break;
                 }
-                ++worker;
+                ++workers;
             }
         }
     }
@@ -792,8 +796,9 @@ static int balancer_handler(request_rec *r)
             ap_rputs("    <httpd:balancer>\n", r);
             ap_rvputs(r, "      <httpd:name>", balancer->name, "</httpd:name>\n", NULL);
             ap_rputs("      <httpd:workers>\n", r);
-            worker = (proxy_worker *)balancer->workers->elts;
+            workers = (proxy_worker **)balancer->workers->elts;
             for (n = 0; n < balancer->workers->nelts; n++) {
+                worker = *workers;
                 ap_rputs("        <httpd:worker>\n", r);
                 ap_rvputs(r, "          <httpd:scheme>", worker->scheme,
                           "</httpd:scheme>\n", NULL);
@@ -802,7 +807,7 @@ static int balancer_handler(request_rec *r)
                ap_rprintf(r, "          <httpd:loadfactor>%d</httpd:loadfactor>\n",
                           worker->s->lbfactor);
                 ap_rputs("        </httpd:worker>\n", r);
-                ++worker;
+                ++workers;
             }
             ap_rputs("      </httpd:workers>\n", r);
             ap_rputs("    </httpd:balancer>\n", r);
@@ -854,9 +859,10 @@ static int balancer_handler(request_rec *r)
                 "<th>Elected</th><th>To</th><th>From</th>"
                 "</tr>\n", r);
 
-            worker = (proxy_worker *)balancer->workers->elts;
+            workers = (proxy_worker **)balancer->workers->elts;
             for (n = 0; n < balancer->workers->nelts; n++) {
                 char fbuf[50];
+                worker = *workers;
                 ap_rvputs(r, "<tr>\n<td><a href=\"", r->uri, "?b=",
                           balancer->name + sizeof("balancer://") - 1, "&w=",
                           ap_escape_uri(r->pool, worker->name),
@@ -888,7 +894,7 @@ static int balancer_handler(request_rec *r)
                 ap_rputs(apr_strfsize(worker->s->read, fbuf), r);
                 ap_rputs("</td></tr>\n", r);
 
-                ++worker;
+                ++workers;
             }
             ap_rputs("</table>\n", r);
             ++balancer;