Add notes.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@43282 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/CodeGen/CodeGenTypes.cpp b/CodeGen/CodeGenTypes.cpp
index 4aaf13f549e518826dbe01d5d6df3945a2630c9b..04394e38fee293949bbc643cbf11abb976129554 100644 (file)
--- a/CodeGen/CodeGenTypes.cpp
+++ b/CodeGen/CodeGenTypes.cpp
@@ -176,6 +176,8 @@ const llvm::Type *CodeGenTypes::ConvertType(QualType T) {
         return OpaqueI->second;
 
       // Create new OpaqueType now for later use.
+      // FIXME: This creates a lot of opaque types, most of which are not needed.  
+      // Reevaluate this when performance analyis finds tons of opaque types.
       llvm::OpaqueType *OpaqueTy =  llvm::OpaqueType::get();
       RecordTypesToResolve[RD] = OpaqueTy;
 

diff --git a/CodeGen/CodeGenTypes.h b/CodeGen/CodeGenTypes.h
index f149fb801d1baa112cbe49b0d7f4fba75b23c525..7ab3afe2e108865af0813ab789616592452663d9 100644 (file)
--- a/CodeGen/CodeGenTypes.h
+++ b/CodeGen/CodeGenTypes.h
@@ -94,6 +94,8 @@ class CodeGenTypes {
 
   /// RecordLayouts - This maps llvm struct type with corresponding 
   /// record layout info. 
+  /// FIXME : If RecordLayoutInfo is less than 16 bytes then use 
+  /// inline it in the map.
   llvm::DenseMap<const llvm::Type*, RecordLayoutInfo *> RecordLayouts;
 
   /// FieldInfo - This maps struct field with corresponding llvm struct type