]> granicus.if.org Git - libvpx/commitdiff
add worst-case frame size cap
authorJohann <johannkoenig@google.com>
Tue, 6 Mar 2018 02:51:10 +0000 (18:51 -0800)
committerJohann <johannkoenig@google.com>
Tue, 6 Mar 2018 04:09:43 +0000 (20:09 -0800)
The largest frame is currently in choose_partitioning:
warning: stack frame size of 44156 bytes in function 'choose_partitioning'

but adding HBD amplifies other things:
warning: stack frame size of 51480 bytes in function 'dec_build_inter_predictors'

Add some padding for sanitizer and variances between compilers.

BUG=webm:1498

Change-Id: I0d94d4f94d25dafafca9d7484881c2ce5f8de371

configure

index e5a74c6f2ab85cdfe37a16ec803ed9f63fa70241..6e7630ebac32f277263e0d52835199508c4a059c 100755 (executable)
--- a/configure
+++ b/configure
@@ -606,8 +606,10 @@ process_toolchain() {
         # https://bugs.chromium.org/p/webm/issues/detail?id=1069
         check_add_cflags -Wextra
         # check_add_cflags also adds to cxxflags. gtest does not do well with
-        # -Wundef so add it explicitly to CFLAGS only.
+        # these flags so add them explicitly to CFLAGS only.
         check_cflags -Wundef && add_cflags_only -Wundef
+        check_cflags -Wframe-larger-than=52000 && \
+          add_cflags_only -Wframe-larger-than=52000
         if enabled mips || [ -z "${INLINE}" ]; then
           enabled extra_warnings || check_add_cflags -Wno-unused-function
         fi