]> granicus.if.org Git - php/commitdiff
Fixed bug #61088 (Memory leak in readline_callback_handler_install).
authorXinchen Hui <laruence@php.net>
Sun, 11 Mar 2012 09:19:38 +0000 (09:19 +0000)
committerXinchen Hui <laruence@php.net>
Sun, 11 Mar 2012 09:19:38 +0000 (09:19 +0000)
ext/readline/readline.c

index 22521e60406c08a5e761cc9150ab56c9503c70b1..c9389fc8ebce719edef62da467d22bdc04442ce5 100644 (file)
@@ -576,9 +576,8 @@ PHP_FUNCTION(readline_callback_handler_install)
                FREE_ZVAL(_prepped_callback);
        }
 
-       MAKE_STD_ZVAL(_prepped_callback);
-       *_prepped_callback = *callback;
-       zval_copy_ctor(_prepped_callback);
+       ALLOC_ZVAL(_prepped_callback);
+       MAKE_COPY_ZVAL(&callback, _prepped_callback);
 
        rl_callback_handler_install(prompt, php_rl_callback_handler);