]> granicus.if.org Git - php/commitdiff
fix #37392 (Unnecessary call to OCITransRollback() at the end of request)
authorAntony Dovgal <tony2001@php.net>
Wed, 10 May 2006 10:06:57 +0000 (10:06 +0000)
committerAntony Dovgal <tony2001@php.net>
Wed, 10 May 2006 10:06:57 +0000 (10:06 +0000)
ext/oci8/oci8.c

index 1c73008ed457fed10a71fdce3796e1e25155ed7e..adb6fb298e0d75ea112b88a0cabebfa961c20dc9 100644 (file)
@@ -1718,7 +1718,9 @@ static int php_oci_persistent_helper(zend_rsrc_list_entry *le TSRMLS_DC)
                                connection->descriptors = NULL;
                        }
                        
-                       php_oci_connection_rollback(connection TSRMLS_CC);
+                       if (connection->needs_commit) {
+                               php_oci_connection_rollback(connection TSRMLS_CC);
+                       }
                        
                        if (OCI_G(persistent_timeout) > 0) {
                                connection->idle_expiry = timestamp + OCI_G(persistent_timeout);