]> granicus.if.org Git - pdns/commitdiff
we shadowed the length variable on a successful cache hit that was
authorbert hubert <bert.hubert@powerdns.com>
Sun, 7 Oct 2018 14:46:30 +0000 (16:46 +0200)
committerRemi Gacogne <remi.gacogne@powerdns.com>
Thu, 10 Jan 2019 09:54:09 +0000 (10:54 +0100)
ECS-invariable

pdns/dnsdist.cc

index 5fa255798208934c3cc0f96f5c31abd094db2bcb..213ea51fecd8fcb6487f076d4b1763188c112b8c 100644 (file)
@@ -1417,8 +1417,6 @@ static void processUDPQuery(ClientState& cs, LocalHolders& holders, const struct
         dnssecOK = (getEDNSZ(dq) & EDNS_HEADER_FLAG_DO);
       }
 
-      uint16_t cachedResponseSize = dq.size;
-      uint32_t allowExpired = ss ? 0 : g_staleCacheEntriesTTL;
       boost::optional<Netmask> subnet;
       if (packetCache && !dq.skipCache && packetCache->get(dq, consumed, dh->id, query, &cachedResponseSize, &cacheKeyNoECS, subnet, dnssecOK, allowExpired)) {
         goto sendIt;