we shadowed the length variable on a successful cache hit that was

ECS-invariable

diff --git a/pdns/dnsdist.cc b/pdns/dnsdist.cc
index 5fa255798208934c3cc0f96f5c31abd094db2bcb..213ea51fecd8fcb6487f076d4b1763188c112b8c 100644 (file)
--- a/pdns/dnsdist.cc
+++ b/pdns/dnsdist.cc
@@ -1417,8 +1417,6 @@ static void processUDPQuery(ClientState& cs, LocalHolders& holders, const struct
         dnssecOK = (getEDNSZ(dq) & EDNS_HEADER_FLAG_DO);
       }
 
-      uint16_t cachedResponseSize = dq.size;
-      uint32_t allowExpired = ss ? 0 : g_staleCacheEntriesTTL;
       boost::optional<Netmask> subnet;
       if (packetCache && !dq.skipCache && packetCache->get(dq, consumed, dh->id, query, &cachedResponseSize, &cacheKeyNoECS, subnet, dnssecOK, allowExpired)) {
         goto sendIt;