]> granicus.if.org Git - php/commitdiff
MFB: Fixed bug #38319 (Remove bogus warnings from persistent PDO connections).
authorIlia Alshanetsky <iliaa@php.net>
Mon, 4 Dec 2006 03:08:52 +0000 (03:08 +0000)
committerIlia Alshanetsky <iliaa@php.net>
Mon, 4 Dec 2006 03:08:52 +0000 (03:08 +0000)
ext/pdo/pdo_stmt.c

index cc9eea7be06d84b2814d0299ba862e88c92e045e..bba8d0e914e0ad6a82f34be4643b722cd29edc19 100755 (executable)
@@ -1762,12 +1762,11 @@ fail_out:
                        
                        stmt->fetch.cls.ce = *cep;
                        stmt->fetch.cls.ctor_args = NULL;
-
+#ifdef ilia_0 /* we'll only need this when we have persistent statements, if ever */
                        if (stmt->dbh->is_persistent) {
-                               /* TODO: CRITICAL for final release */
                                php_error_docref(NULL TSRMLS_CC, E_WARNING, "PHP might crash if you don't call $stmt->setFetchMode() to reset to defaults on this persistent statement.  This will be fixed in a later release");
                        }
-                       
+#endif
                        if (argc == 3) {
                                if (Z_TYPE_PP(args[skip+2]) != IS_NULL && Z_TYPE_PP(args[skip+2]) != IS_ARRAY) {
                                        pdo_raise_impl_error(stmt->dbh, stmt, "HY000", "ctor_args must be either NULL or an array" TSRMLS_CC);
@@ -1788,11 +1787,11 @@ fail_out:
                        if (Z_TYPE_PP(args[skip+1]) != IS_OBJECT) {
                                goto fail_out;
                        }
-
+#ifdef ilia_0 /* we'll only need this when we have persistent statements, if ever */
                        if (stmt->dbh->is_persistent) {
                                php_error_docref(NULL TSRMLS_CC, E_WARNING, "PHP might crash if you don't call $stmt->setFetchMode() to reset to defaults on this persistent statement.  This will be fixed in a later release");
                        }
-       
+#endif
                        MAKE_STD_ZVAL(stmt->fetch.into);
 
                        Z_TYPE_P(stmt->fetch.into) = IS_OBJECT;