Fix crash in pg_replication_slot_advance

We were trying to use a LSN variable after releasing its containing slot
structure.

Reported by: tushar
Author: amul sul
Reviewed-by: Petr Jelinek, Masahiko Sawada
Discussion: https://postgr.es/m/94ba999c-f76a-0423-6523-b8d531dfe4c7@enterprisedb.com

diff --git a/src/backend/replication/slotfuncs.c b/src/backend/replication/slotfuncs.c
index cf2195bc93fb53c40e32aa881a84215c93ded2c5..e873dd1f81a55d9b5b286738f78f45e7450ebcda 100644 (file)
--- a/src/backend/replication/slotfuncs.c
+++ b/src/backend/replication/slotfuncs.c
@@ -480,8 +480,7 @@ pg_replication_slot_advance(PG_FUNCTION_ARGS)
                                (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
                                 errmsg("cannot move slot to %X/%X, minimum is %X/%X",
                                                (uint32) (moveto >> 32), (uint32) moveto,
-                                               (uint32) (MyReplicationSlot->data.confirmed_flush >> 32),
-                                               (uint32) (MyReplicationSlot->data.confirmed_flush))));
+                                               (uint32) (startlsn >> 32), (uint32) startlsn)));
        }
 
        if (OidIsValid(MyReplicationSlot->data.database))