Forget SMTP password if authentication fails.

Thanks to Gregory Shapiro for the initial patch (I've moved the reset
from smtp_auth_sasl up to smtp_auth, and used the account API
instead of twiddling account bits by hand). Closes #2872.

diff --git a/ChangeLog b/ChangeLog
index 7039481dadd9fd38ccd9d85a1e7ed25f242c9472..f83ee573105388b157f6d385c1addead1bf82253 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,17 @@
+2007-05-08 12:54 -0700  Rocco Rutte  <pdmef@gmx.net>  (763bd781d108)
+
+       * rfc3676.c: f=f: flush buffer contents (if any) after reading input
+       Otherwise mutt maybe won't show the last line if it's supposed to
+       continue.
+
+2007-05-07 11:50 -0700  Brendan Cully  <brendan@kublai.com>  (89a3e1c5c28b)
+
+       * OPS, UPDATING, curs_main.c, functions.h: Rename next-folder to next-
+       unread-mailbox. Remove default binding.
+
+       * muttlib.c: Use signed arithmetic in mutt_gecos_name to avoid an
+       overflow. Closes #2885.
+
 2007-05-02 10:50 -0700  N.J. Mann  <njm@njm.f2s.com>  (f6861b85f22b)
 
        * OPS, curs_main.c, functions.h: Add next-folder command

diff --git a/smtp.c b/smtp.c
index 35a1dc82797511ad04de492891c2968a9ffb1d78..89397096dc2b665e1344489f70172f4959dbc05b 100644 (file)
--- a/smtp.c
+++ b/smtp.c
@@ -444,6 +444,9 @@ static int smtp_auth (CONNECTION* conn)
   else
     r = smtp_auth_sasl (conn, AuthMechs);
 
+  if (r != SMTP_AUTH_SUCCESS)
+    mutt_account_unsetpass (&conn->account);
+
   if (r == SMTP_AUTH_UNAVAIL)
   {
     mutt_error (_("No authenticators available"));