Fix sorting by progress (Qt client)

Magnet transfers caused the by-progress sorting to become non-stable, as their
percentComplete() could return NaN. This patch fixes this by preferring active
downloads over magnet transfers, then sorting them by percentComplete().

diff --git a/qt/TorrentFilter.cc b/qt/TorrentFilter.cc
index 07e4ca1168f8744fe80a3c6744d24527162c6d29..6fa78541f05319a72aa03a617fb5a83f694b3e03 100644 (file)
--- a/qt/TorrentFilter.cc
+++ b/qt/TorrentFilter.cc
@@ -155,6 +155,11 @@ bool TorrentFilter::lessThan(QModelIndex const& left, QModelIndex const& right)
     // fall through
 
     case SortMode::SORT_BY_PROGRESS:
+        if (a->isMagnet() != b->isMagnet())
+        {
+            val = -compare(a->isMagnet(), b->isMagnet());
+        }
+
         if (val == 0)
         {
             val = compare(a->percentComplete(), b->percentComplete());