]> granicus.if.org Git - zfs/commitdiff
Improve "Unable to automount" error message.
authorPaul Zuchowski <31706010+PaulZ-98@users.noreply.github.com>
Wed, 3 Jul 2019 20:05:02 +0000 (16:05 -0400)
committerBrian Behlendorf <behlendorf1@llnl.gov>
Wed, 3 Jul 2019 20:05:02 +0000 (13:05 -0700)
Having the mountpoint and dataset name both in the message made it
confusing to read.  Additionally, convert this to a zfs_dbgmsg rather than
sending it to the console.

Reviewed-by: Tom Caputi <tcaputi@datto.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Paul Zuchowski <pzuchowski@datto.com>
Closes #8959

module/zfs/zfs_ctldir.c

index aa50646fef83115f320d72be92fbeca6648a54f2..52314f4e1bdb417c1eaddbcc65987ce8cb3a092c 100644 (file)
@@ -30,6 +30,7 @@
  * Copyright (c) 2013 by Delphix. All rights reserved.
  * Copyright 2015, OmniTI Computer Consulting, Inc. All rights reserved.
  * Copyright (c) 2018 George Melikov. All Rights Reserved.
+ * Copyright (c) 2019 Datto, Inc. All rights reserved.
  */
 
 /*
@@ -1081,8 +1082,8 @@ zfsctl_snapshot_mount(struct path *path, int flags)
        error = call_usermodehelper(argv[0], argv, envp, UMH_WAIT_PROC);
        if (error) {
                if (!(error & MOUNT_BUSY << 8)) {
-                       cmn_err(CE_WARN, "Unable to automount %s/%s: %d",
-                           full_path, full_name, error);
+                       zfs_dbgmsg("Unable to automount %s error=%d",
+                           full_path, error);
                        error = SET_ERROR(EISDIR);
                } else {
                        /*