Reset the layout of an ObjC class if we see an ivar in a category

or implementation since we've now got a different layout.

Fixes rdar://11842763

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@160526 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/lib/Sema/SemaDecl.cpp b/lib/Sema/SemaDecl.cpp
index 4ea8df8b661bb4e57a6070d1a7939e304ef61c32..430ce9f7f7844c1073fe060895fe35be69cea38d 100644 (file)
--- a/lib/Sema/SemaDecl.cpp
+++ b/lib/Sema/SemaDecl.cpp
@@ -9802,6 +9802,23 @@ void Sema::ActOnFields(Scope* S,
   if (EnclosingDecl->isInvalidDecl())
     return;
 
+  // If this is an Objective-C @implementation or category and we have
+  // new fields here we should reset the layout of the interface since
+  // it will now change.
+  if (!Fields.empty() && isa<ObjCContainerDecl>(EnclosingDecl)) {
+    ObjCContainerDecl *DC = cast<ObjCContainerDecl>(EnclosingDecl);
+    switch (DC->getKind()) {
+    default: break;
+    case Decl::ObjCCategory:
+      Context.ResetObjCLayout(cast<ObjCCategoryDecl>(DC)->getClassInterface());
+      break;
+    case Decl::ObjCImplementation:
+      Context.
+        ResetObjCLayout(cast<ObjCImplementationDecl>(DC)->getClassInterface());
+      break;
+    }
+  }
+  
   RecordDecl *Record = dyn_cast<RecordDecl>(EnclosingDecl);
 
   // Start counting up the number of named members; make sure to include

diff --git a/test/CodeGenObjC/layout-bitfield-crash.m b/test/CodeGenObjC/layout-bitfield-crash.m
new file mode 100644 (file)
index 0000000..7e6e77e
--- /dev/null
+++ b/test/CodeGenObjC/layout-bitfield-crash.m
@@ -0,0 +1,35 @@
+// RUN: %clang_cc1 -triple x86_64-apple-darwin11 -fobjc-runtime=macosx-10.7 -fobjc-gc -emit-llvm -g -o - %s
+// Check that this doesn't crash when compiled with debugging on.
+@class Foo;
+typedef struct Bar *BarRef;
+
+@interface Baz
+@end
+
+@interface Foo
+- (void) setFlag;
+@end
+
+@implementation Baz
+
+- (void) a:(BarRef)b
+{
+  Foo* view = (Foo*)self;
+  [view setFlag];
+}
+
+@end
+
+
+@implementation Foo
+{
+  int flag : 1;
+}
+
+- (void) setFlag
+{
+  if (!flag)
+    flag = 1;
+}
+
+@end