]> granicus.if.org Git - python/commitdiff
Issue #18940: Handled low-volume logging when delay is True.
authorVinay Sajip <vinay_sajip@yahoo.co.uk>
Fri, 6 Sep 2013 09:09:45 +0000 (10:09 +0100)
committerVinay Sajip <vinay_sajip@yahoo.co.uk>
Fri, 6 Sep 2013 09:09:45 +0000 (10:09 +0100)
Lib/logging/handlers.py

index c4b8746ee5a98e2692657cd1caf86f41f09997ba..8a813d3e375ef046da879642e989361e8df24a8b 100644 (file)
@@ -137,7 +137,9 @@ class RotatingFileHandler(BaseRotatingHandler):
             dfn = self.baseFilename + ".1"
             if os.path.exists(dfn):
                 os.remove(dfn)
-            os.rename(self.baseFilename, dfn)
+            # Issue 18940: A file may not have been created if delay is True.
+            if os.path.exists(self.baseFilename):
+                os.rename(self.baseFilename, dfn)
             #print "%s -> %s" % (self.baseFilename, dfn)
         self.stream = self._open()
 
@@ -343,7 +345,9 @@ class TimedRotatingFileHandler(BaseRotatingHandler):
         dfn = self.baseFilename + "." + time.strftime(self.suffix, timeTuple)
         if os.path.exists(dfn):
             os.remove(dfn)
-        os.rename(self.baseFilename, dfn)
+        # Issue 18940: A file may not have been created if delay is True.
+        if os.path.exists(self.baseFilename):
+            os.rename(self.baseFilename, dfn)
         if self.backupCount > 0:
             # find the oldest log file and delete it
             #s = glob.glob(self.baseFilename + ".20*")