Merged revisions 78431 via svnmerge from

svn+ssh://pythondev@svn.python.org/python/trunk

........
  r78431 | senthil.kumaran | 2010-02-25 02:25:31 +0530 (Thu, 25 Feb 2010) | 4 lines

  Fix for Issue7540 ; urllib2 will raise a TypeError when you try to add_data to
  a existing req object already having data.
........

diff --git a/Lib/test/test_urllib2.py b/Lib/test/test_urllib2.py
index 11848e07e47b8c491a2b00489fa4b5f1e927047c..080c2f1f492f81459e786eaa58cc5733af41ef2b 100644 (file)
--- a/Lib/test/test_urllib2.py
+++ b/Lib/test/test_urllib2.py
@@ -1220,6 +1220,7 @@ class RequestTests(unittest.TestCase):
         self.get.add_data("spam")
         self.assertTrue(self.get.has_data())
         self.assertEqual("POST", self.get.get_method())
+        self.assertRaises(TypeError,self.get.add_data, "more spam")
 
     def test_get_full_url(self):
         self.assertEqual("http://www.python.org/~jeremy/",

diff --git a/Lib/urllib/request.py b/Lib/urllib/request.py
index b9de4793b3de61dea51ab353675e50a3d249eb36..5bdc103563edfc4f9a5d712553860c2cef431ca1 100644 (file)
--- a/Lib/urllib/request.py
+++ b/Lib/urllib/request.py
@@ -192,6 +192,9 @@ class Request:
     # Begin deprecated methods
 
     def add_data(self, data):
+        if self.has_data():
+            raise TypeError("Request Obj already contains data: %s" %
+                            self.data)
         self.data = data
 
     def has_data(self):