- don't write directly to stderr, use the internal logger instead (zlog)

diff --git a/sapi/fpm/fpm/fpm_main.c b/sapi/fpm/fpm/fpm_main.c
index 0648b0c73b93c67dfb8c2e4ee93b1ecb990c8323..f362a2cbc3f5d0b1d0a313de869317dfcc97bc5d 100644 (file)
--- a/sapi/fpm/fpm/fpm_main.c
+++ b/sapi/fpm/fpm/fpm_main.c
@@ -620,22 +620,7 @@ static void sapi_cgi_register_variables(zval *track_vars_array TSRMLS_DC)
 static void sapi_cgi_log_message(char *message TSRMLS_DC)
 {
        if (CGIG(fcgi_logging)) {
-               fcgi_request *request;
-
-               request = (fcgi_request*) SG(server_context);
-               if (request) {
-                       int len = strlen(message);
-                       char *buf = malloc(len+2);
-
-                       memcpy(buf, message, len);
-                       memcpy(buf + len, "\n", sizeof("\n"));
-                       fcgi_write(request, FCGI_STDERR, buf, len+1);
-                       free(buf);
-               } else {
-                       fprintf(stderr, "%s\n", message);
-                       //FIXME zlog(ZLOG_NOTICE, "PHP message: %s", message);
-               }
-               /* ignore return code */
+               zlog(ZLOG_NOTICE, "PHP message: %s", message);
        }
 }
 
@@ -1349,17 +1334,17 @@ static void fastcgi_ini_parser(zval *arg1, zval *arg2, zval *arg3, int callback_
        if (!mode) return;
 
        if (callback_type != ZEND_INI_PARSER_ENTRY) {
-               fprintf(stderr, "Passing INI directive through FastCGI: only classic entries are allowed\n");
+               zlog(ZLOG_ERROR, "Passing INI directive through FastCGI: only classic entries are allowed");
                return;
        }
 
        if (!key || strlen(key) < 1) {
-               fprintf(stderr, "Passing INI directive through FastCGI: empty key\n");
+               zlog(ZLOG_ERROR, "Passing INI directive through FastCGI: empty key");
                return;
        }
 
        if (!value) {
-               fprintf(stderr, "Passing INI directive through FastCGI: empty value for key '%s'\n", key);
+               zlog(ZLOG_ERROR, "Passing INI directive through FastCGI: empty value for key '%s'", key);
                return;
        }
 
@@ -1367,7 +1352,7 @@ static void fastcgi_ini_parser(zval *arg1, zval *arg2, zval *arg3, int callback_
        kv.value = value;
        kv.next = NULL;
        if (fpm_php_apply_defines_ex(&kv, *mode) == -1) {
-               fprintf(stderr, "Passing INI directive through FastCGI: unable to set '%s'\n", key);
+               zlog(ZLOG_ERROR, "Passing INI directive through FastCGI: unable to set '%s'", key);
        }
 }
 /* }}} */

diff --git a/sapi/fpm/fpm/fpm_php.c b/sapi/fpm/fpm/fpm_php.c
index f320f5148e6be631226e6bfbce935d8df9496d32..d541f2944618a1647c88566a4fb8fb73045bb00e 100644 (file)
--- a/sapi/fpm/fpm/fpm_php.c
+++ b/sapi/fpm/fpm/fpm_php.c
@@ -120,13 +120,13 @@ static int fpm_php_apply_defines(struct fpm_worker_pool_s *wp) /* {{{ */
 
        for (kv = wp->config->php_values; kv; kv = kv->next) {
                if (fpm_php_apply_defines_ex(kv, ZEND_INI_USER) == -1) {
-                       fprintf(stderr, "Unable to set php_value '%s'", kv->key);
+                       zlog(ZLOG_ERROR, "Unable to set php_value '%s'", kv->key);
                }
        }
 
        for (kv = wp->config->php_admin_values; kv; kv = kv->next) {
                if (fpm_php_apply_defines_ex(kv, ZEND_INI_SYSTEM) == -1) {
-                       fprintf(stderr, "Unable to set php_admin_value '%s'", kv->key);
+                       zlog(ZLOG_ERROR, "Unable to set php_admin_value '%s'", kv->key);
                }
        }