(main): Before pam_end(), the return value of the previous pam API was already

checked. No need to validate it again.

diff --git a/ChangeLog b/ChangeLog
index 7b323d441dc6d1f1bf724e0ddbeffeed7366f383..d125fc0b4b90f65092e3d16af3c0432a7b21827b 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -8,6 +8,8 @@
        GID is specified with -g. Simplify find_new_gid accordingly.
        * src/groupadd.c (process_flags): prefer fail_exit to exit. This avoid
        an explicit call to audit_logger().
+       * src/groupadd.c (main): Before pam_end(), the return value of the
+       previous pam API was already checked. No need to validate it again.
 
 2007-12-28  Nicolas François  <nicolas.francois@centraliens.net>
 

diff --git a/src/groupadd.c b/src/groupadd.c
index ae90d18681e5c19596ef95c6813157ddfd681e43..05e3ff525c833db4277d08c054d8adc04c1fd3bc 100644 (file)
--- a/src/groupadd.c
+++ b/src/groupadd.c
@@ -564,10 +564,9 @@ int main (int argc, char **argv)
        nscd_flush_cache ("group");
 
 #ifdef USE_PAM
-       if (retval == PAM_SUCCESS) {
-               pam_end (pamh, PAM_SUCCESS);
-       }
+       pam_end (pamh, PAM_SUCCESS);
 #endif                         /* USE_PAM */
+
        exit (E_SUCCESS);
        /* NOT REACHED */
 }