ICU-11986 slightly nicer QuantityFormatter.getPluralIndex(), avoid key.toString(...

X-SVN-Rev: 38096

diff --git a/icu4j/main/classes/core/src/com/ibm/icu/text/MeasureFormat.java b/icu4j/main/classes/core/src/com/ibm/icu/text/MeasureFormat.java
index 7899bcedae060836790c6de89e9a492b9438b328..7e9f0d8d64b19946576054af237b1ee1a4237cbc 100644 (file)
--- a/icu4j/main/classes/core/src/com/ibm/icu/text/MeasureFormat.java
+++ b/icu4j/main/classes/core/src/com/ibm/icu/text/MeasureFormat.java
@@ -760,7 +760,7 @@ public class MeasureFormat extends UFormat {
                     // one{"{0} hr"}
                     // other{"{0} hrs"}
                     if (!hasPatterns) {
-                        builder.add(key.toString(), value.getString());
+                        builder.add(key, value.getString());
                     }
                 }
             }

diff --git a/icu4j/main/classes/core/src/com/ibm/icu/text/QuantityFormatter.java b/icu4j/main/classes/core/src/com/ibm/icu/text/QuantityFormatter.java
index e72f199678fd3343369979f6d9ca920881b0d397..17b9a8288953f5dd69a09a3598660a4f375f0719 100644 (file)
--- a/icu4j/main/classes/core/src/com/ibm/icu/text/QuantityFormatter.java
+++ b/icu4j/main/classes/core/src/com/ibm/icu/text/QuantityFormatter.java
@@ -21,28 +21,31 @@ class QuantityFormatter {
      * Plural forms in index order: "other", "zero", "one", "two", "few", "many"
      * "other" must be first.
      */
-    private static final int getPluralIndex(String pluralForm) {
-        if (pluralForm.equals("other")) {
-            return 0;
-        }
-        if (pluralForm.length() == 3) {
-            if (pluralForm.equals("one")) {
+    private static final int getPluralIndex(CharSequence pluralForm) {
+        switch (pluralForm.length()) {
+        case 3:
+            if ("one".contentEquals(pluralForm)) {
                 return 2;
-            }
-            if (pluralForm.equals("two")) {
+            } else if ("two".contentEquals(pluralForm)) {
                 return 3;
-            }
-            if (pluralForm.equals("few")) {
+            } else if ("few".contentEquals(pluralForm)) {
                 return 4;
             }
-        }
-        if (pluralForm.length() == 4) {
-            if (pluralForm.equals("many")) {
+            break;
+        case 4:
+            if ("many".contentEquals(pluralForm)) {
                 return 5;
-            }
-            if (pluralForm.equals("zero")) {
+            } else if ("zero".contentEquals(pluralForm)) {
                 return 1;
             }
+            break;
+        case 5:
+            if ("other".contentEquals(pluralForm)) {
+                return 0;
+            }
+            break;
+        default:
+            break;
         }
         return -1;
     }
@@ -70,10 +73,10 @@ class QuantityFormatter {
          * @throws IllegalArgumentException if variant is not recognized or
          *  if template has more than just the {0} placeholder.
          */
-        public Builder add(String variant, String template) {
+        public Builder add(CharSequence variant, String template) {
             int idx = getPluralIndex(variant);
             if (idx < 0) {
-                throw new IllegalArgumentException(variant);
+                throw new IllegalArgumentException(variant.toString());
             }
             SimplePatternFormatter newT = SimplePatternFormatter.compile(template);
             if (newT.getPlaceholderCount() > 1) {
@@ -142,7 +145,7 @@ class QuantityFormatter {
      * @param variant "zero", "one", "two", "few", "many", "other"
      * @return the SimplePatternFormatter
      */
-    public SimplePatternFormatter getByVariant(String variant) {
+    public SimplePatternFormatter getByVariant(CharSequence variant) {
         int idx = getPluralIndex(variant);
         SimplePatternFormatter template = templates[idx < 0 ? 0 : idx];
         return template == null ? templates[0] : template;