]> granicus.if.org Git - php/commitdiff
Promote warnings to errors in assert_options()
authorGeorge Peter Banyard <girgias@php.net>
Wed, 28 Aug 2019 21:57:51 +0000 (23:57 +0200)
committerGeorge Peter Banyard <girgias@php.net>
Thu, 29 Aug 2019 21:10:37 +0000 (23:10 +0200)
ext/standard/assert.c
ext/standard/tests/assert/assert_options_error.phpt [new file with mode: 0644]

index ffd33638615a74311b25d04dcad2f79c17b2617d..b5b8e910be03e29f9893a7b9dd1121d7e8d341f6 100644 (file)
@@ -316,10 +316,10 @@ PHP_FUNCTION(assert_options)
                break;
 
        default:
-               php_error_docref(NULL, E_WARNING, "Unknown value " ZEND_LONG_FMT, what);
+               zend_throw_error(NULL, "Unknown value " ZEND_LONG_FMT, what);
                break;
        }
 
-       RETURN_FALSE;
+       return;
 }
 /* }}} */
diff --git a/ext/standard/tests/assert/assert_options_error.phpt b/ext/standard/tests/assert/assert_options_error.phpt
new file mode 100644 (file)
index 0000000..0b50370
--- /dev/null
@@ -0,0 +1,13 @@
+--TEST--
+assert_options() - unknown assert option.
+
+--FILE--
+<?php
+try {
+    assert_options(1000);
+} catch (\Error $e) {
+    echo $e->getMessage();
+}
+?>
+--EXPECT--
+Unknown value 1000
\ No newline at end of file