API: Fix requested attrs/joins/meta type errors in object query response

fixes #5377

Signed-off-by: Michael Friedrich <michael.friedrich@icinga.com>

diff --git a/lib/remote/objectqueryhandler.cpp b/lib/remote/objectqueryhandler.cpp
index 836e4510a3913f4b7928e88496bc9e07c11ca1bc..db731396a521b539c7e29e57f1b91633c5752dbc 100644 (file)
--- a/lib/remote/objectqueryhandler.cpp
+++ b/lib/remote/objectqueryhandler.cpp
@@ -123,9 +123,32 @@ bool ObjectQueryHandler::HandleRequest(const ApiUser::Ptr& user, HttpRequest& re
        qd.Types.insert(type->GetName());
        qd.Permission = "objects/query/" + type->GetName();
 
-       Array::Ptr uattrs = params->Get("attrs");
-       Array::Ptr ujoins = params->Get("joins");
-       Array::Ptr umetas = params->Get("meta");
+       Array::Ptr uattrs, ujoins, umetas;
+
+       try {
+               uattrs = params->Get("attrs");
+       } catch (const std::exception&) {
+               HttpUtility::SendJsonError(response, 400,
+                    "Invalid type for 'attrs' attribute specified. Array type is required.", Empty);
+                return true;
+       }
+
+       try {
+               ujoins = params->Get("joins");
+       } catch (const std::exception&) {
+               HttpUtility::SendJsonError(response, 400,
+                    "Invalid type for 'joins' attribute specified. Array type is required.", Empty);
+                return true;
+       }
+
+       try {
+               umetas = params->Get("meta");
+       } catch (const std::exception&) {
+               HttpUtility::SendJsonError(response, 400,
+                    "Invalid type for 'meta' attribute specified. Array type is required.", Empty);
+               return true;
+       }
+
        bool allJoins = HttpUtility::GetLastParameter(params, "all_joins");
 
        params->Set("type", type->GetName());