Allow pg_upgrade to upgrade clusters that use exclusion contraints by

fixing pg_dump to properly preserve such indexes.

Backpatch to 9.1 and 9.0 (where the bug was introduced).

diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
index b8809fe1e6f9779488739596df00d210f44a0386..7a65091450e6bd1f5869acd7b7b78573bf553707 100644 (file)
--- a/src/bin/pg_dump/pg_dump.c
+++ b/src/bin/pg_dump/pg_dump.c
@@ -12708,7 +12708,7 @@ dumpConstraint(Archive *fout, ConstraintInfo *coninfo)
                        exit_nicely();
                }
 
-               if (binary_upgrade && !coninfo->condef)
+               if (binary_upgrade)
                        binary_upgrade_set_pg_class_oids(q, indxinfo->dobj.catId.oid, true);
 
                appendPQExpBuffer(q, "ALTER TABLE ONLY %s\n",