]> granicus.if.org Git - zfs/commitdiff
Fix coverity defects: CID 161264
authorGiuseppe Di Natale <dinatale2@users.noreply.github.com>
Wed, 5 Apr 2017 20:21:10 +0000 (13:21 -0700)
committerBrian Behlendorf <behlendorf1@llnl.gov>
Wed, 5 Apr 2017 20:21:10 +0000 (13:21 -0700)
CID 161264:  Uninitialized variables  (UNINIT)

In _zed_event_add_nvpair, when handling DATA_TYPE_UINT64,
we should be using i64 throughout the entire case.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Don Brady <don.brady@intel.com>
Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Closes #5964

cmd/zed/zed_event.c

index aecdb5146bc8265ccbfcdf8d71fa43a954f30c5b..390235019b368be883793f306e8f3c729a989315 100644 (file)
@@ -662,7 +662,7 @@ _zed_event_add_nvpair(uint64_t eid, zed_strings_t *zsp, nvpair_t *nvp)
 
                        (void) snprintf(alt, sizeof (alt), "%s_str", name);
                        _zed_event_add_var(eid, zsp, prefix, alt, "%s",
-                           zpool_pool_state_to_name(i32));
+                           zpool_pool_state_to_name(i64));
                }
                break;
        case DATA_TYPE_DOUBLE: