fix: in SVG output, set opacity 0 for text with 0 alpha value

Gitlab: fixes #146

diff --git a/CHANGELOG.md b/CHANGELOG.md
index a6015198067af83302475995113191a7c7fe453c..652afa385200c880ae582c0cb5932a8f0e743d5c 100644 (file)
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Failed assertion in `chkSgraph` for dot layout and ortho splines. #1408
 - Failed assertion in `chkSgraph` for circo layout and ortho splines. #1990
 - Segmentation Fault with splines="ortho". #1658
+- Transparent Label appear in SVG output #146
 
 ## [4.0.0] – 2022-05-29
 

diff --git a/plugin/core/gvrender_core_svg.c b/plugin/core/gvrender_core_svg.c
index 97d9204b7c7491e7a5204dc8fe3e51ad40fc7c96..6c1a65223a89ba8cfb6436c086bb382c06b67d54 100644 (file)
--- a/plugin/core/gvrender_core_svg.c
+++ b/plugin/core/gvrender_core_svg.c
@@ -463,7 +463,7 @@ static void svg_textspan(GVJ_t * job, pointf p, textspan_t * span)
        gvprintf(job, " fill=\"#%02x%02x%02x\"",
                 obj->pencolor.u.rgba[0], obj->pencolor.u.rgba[1],
                 obj->pencolor.u.rgba[2]);
-       if (obj->pencolor.u.rgba[3] > 0 && obj->pencolor.u.rgba[3] < 255)
+       if (obj->pencolor.u.rgba[3] < 255)
            gvprintf(job, " fill-opacity=\"%f\"", ((float) obj->pencolor.u.rgba[3] / 255.0));
        break;
     default:

diff --git a/tests/test_regression.py b/tests/test_regression.py
index 0a0c60f2aa772a33215029bf29872568ebbebd77..96456e63b18455e3568de70031244e9f09d653af 100644 (file)
--- a/tests/test_regression.py
+++ b/tests/test_regression.py
@@ -173,7 +173,6 @@ def test_144(testcase: str):
   # this should be consistent with the direction the edge is drawn
   assert routed_up == head_is_top, "heap/tail confusion"
 
-@pytest.mark.xfail(strict=True)
 def test_146():
   """
   dot should respect an alpha channel value of 0 when writing SVG