patch 8.2.2919: using ":!command" does not work if it uses posix_spawn()

Problem:    Using ":!command" does not work if the command uses posix_spawn().
Solution:   Do not call ioctl() with TIOCSCTTY. (Felipe Contreras)

diff --git a/src/os_unix.c b/src/os_unix.c
index 20c61106f90b941abcd6ab3bae9cf375af069a24..0a4f0e6981cc4bc440e1f2f6c46f0fae8cdb3a54 100644 (file)
--- a/src/os_unix.c
+++ b/src/os_unix.c
@@ -4775,11 +4775,6 @@ mch_call_shell_fork(
                    // push stream discipline modules
                    if (options & SHELL_COOKED)
                        setup_slavepty(pty_slave_fd);
-#  ifdef TIOCSCTTY
-                   // Try to become controlling tty (probably doesn't work,
-                   // unless run by root)
-                   ioctl(pty_slave_fd, TIOCSCTTY, (char *)NULL);
-#  endif
                }
 # endif
                set_default_child_environment(FALSE);

diff --git a/src/version.c b/src/version.c
index c1fdb649d4c24f90ec937aaafe06072db97eccc3..a9a7b29f51a57f98f31ff3118371dddbbd4ca333 100644 (file)
--- a/src/version.c
+++ b/src/version.c
@@ -750,6 +750,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    2919,
 /**/
     2918,
 /**/