Issue #15494: test.support is now a package rather than a module

Also including this change in 3.3 to help avoid spurious conflicts
between the two most active branches.

(Initial patch by Indra Talip)

diff --git a/Lib/test/support.py b/Lib/test/support/__init__.py
similarity index 99%
rename from Lib/test/support.py
rename to Lib/test/support/__init__.py
index 7ab5ff7d3168913868309b3a55037cbf57fe3019..3ebc49dd2e0d40da968a27285a78bebf5719aff2 100644 (file)
--- a/Lib/test/support.py
+++ b/Lib/test/support/__init__.py
@@ -787,9 +787,12 @@ if hasattr(os, "umask"):
         finally:
             os.umask(oldmask)
 
+# TEST_HOME refers to the top level directory of the "test" package
+# that contains Python's regression test suite
+TEST_HOME = os.path.dirname(os.path.abspath(__file__))
 
-def findfile(file, here=__file__, subdir=None):
-    """Try to find a file on sys.path and the working directory.  If it is not
+def findfile(file, here=TEST_HOME, subdir=None):
+    """Try to find a file on sys.path or in the test directory.  If it is not
     found the argument passed to the function is returned (this does not
     necessarily signal failure; could still be the legitimate path)."""
     if os.path.isabs(file):

diff --git a/Lib/test/test_linecache.py b/Lib/test/test_linecache.py
index 7d14534d35bdc5755e371241e8127ecc63cca6f4..5fe0554572c102e149c45d3004160870cd9c4612 100644 (file)
--- a/Lib/test/test_linecache.py
+++ b/Lib/test/test_linecache.py
@@ -11,7 +11,7 @@ INVALID_NAME = '!@$)(!@#_1'
 EMPTY = ''
 TESTS = 'inspect_fodder inspect_fodder2 mapping_tests'
 TESTS = TESTS.split()
-TEST_PATH = os.path.dirname(support.__file__)
+TEST_PATH = os.path.dirname(__file__)
 MODULES = "linecache abc".split()
 MODULE_PATH = os.path.dirname(FILENAME)
 

diff --git a/Misc/ACKS b/Misc/ACKS
index 288f18613bb2484e3a1e3cc182e371343fbb7087..aaa8dd4433fdc2e6994bf6e73b2cfb0040d53d19 100644 (file)
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -1202,6 +1202,7 @@ Thenault Sylvain
 Péter Szabó
 Amir Szekely
 Arfrever Frehtes Taifersar Arahesis
+Indra Talip
 Neil Tallim
 Geoff Talvola
 Musashi Tamura

diff --git a/Misc/NEWS b/Misc/NEWS
index ff6fe06db7b4323a7983cddfe68af217350b7188..853e7385239f0965d40d881fd6d9809730805898 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -222,6 +222,9 @@ IDLE
 Tests
 -----
 
+- Issue #15494: test.support is now a package rather than a module (Initial
+  patch by Indra Talip)
+
 - Issue #17944: test_zipfile now discoverable and uses subclassing to
   generate tests for different compression types.  Fixed a bug with skipping
   some tests due to use of exhausted iterators.