Merge r1572561 from trunk:

Avoid useless functions calls.

Submitted by: ylavic
Reviewed/backported by: jim

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1608760 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/STATUS b/STATUS
index 53e5ff733cbc0acf04d62ea75d11e4f778e2ab2f..703fbd349abbf503b94f53abbffc3bf0e453f13b 100644 (file)
--- a/STATUS
+++ b/STATUS
@@ -100,11 +100,6 @@ RELEASE SHOWSTOPPERS:
 PATCHES ACCEPTED TO BACKPORT FROM TRUNK:
   [ start all new proposals below, under PATCHES PROPOSED. ]
 
-   * mod_proxy_http: Avoid useless functions calls.
-     trunk patch: http://svn.apache.org/r1572561
-     2.4.x patch: trunk works
-     +1: ylavic, covener, jim
-
    * mod_proxy: When ping/pong is configured for a worker, don't send or forward
                 "100 Continue" (interim) response to the client if it does not
                 expect one.

diff --git a/modules/proxy/mod_proxy_http.c b/modules/proxy/mod_proxy_http.c
index da18893a12ae9065786236374e7305b8062ef984..141452bf21c09a758a9e75a4afe407da052b09ad 100644 (file)
--- a/modules/proxy/mod_proxy_http.c
+++ b/modules/proxy/mod_proxy_http.c
@@ -1745,7 +1745,6 @@ apr_status_t ap_proxy_http_process_response(apr_pool_t * p, request_rec *r,
 #endif
                     /* sanity check */
                     if (APR_BRIGADE_EMPTY(bb)) {
-                        apr_brigade_cleanup(bb);
                         break;
                     }
 

diff --git a/modules/proxy/proxy_util.c b/modules/proxy/proxy_util.c
index 4f8ee5d5d6f04afda15cc9f8c3011bf34a769bc2..5db7f9c514a991ca26cb6a439169004d0cb52c63 100644 (file)
--- a/modules/proxy/proxy_util.c
+++ b/modules/proxy/proxy_util.c
@@ -2285,6 +2285,7 @@ ap_proxy_determine_connection(apr_pool_t *p, request_rec *r,
                                             conn->pool);
             }
             socket_cleanup(conn);
+            conn->close = 0;
         }
         if (will_reuse) {
             /*