]> granicus.if.org Git - clang/commitdiff
objective-c: provide fixit hint for @autoreleasepool
authorFariborz Jahanian <fjahanian@apple.com>
Mon, 9 Jul 2012 20:00:35 +0000 (20:00 +0000)
committerFariborz Jahanian <fjahanian@apple.com>
Mon, 9 Jul 2012 20:00:35 +0000 (20:00 +0000)
and similar other keywords. // rdar://10723084

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@159956 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Parse/ParseObjc.cpp
test/FixIt/fixit-autoreleasepool.m [new file with mode: 0644]

index 35e4222c52a4e4775dea9c831a63e9721149bc08..857040f265b3b5170a749cba2745b5fc3d117e01 100644 (file)
@@ -2094,8 +2094,23 @@ ExprResult Parser::ParseObjCAtExpression(SourceLocation AtLoc) {
       return ParsePostfixExpressionSuffix(ParseObjCProtocolExpression(AtLoc));
     case tok::objc_selector:
       return ParsePostfixExpressionSuffix(ParseObjCSelectorExpression(AtLoc));
-    default:
-      return ExprError(Diag(AtLoc, diag::err_unexpected_at));
+      default: {
+        const char *str = 0;
+        if (GetLookAheadToken(1).is(tok::l_brace)) {
+          char ch = Tok.getIdentifierInfo()->getNameStart()[0];
+          str =  
+            ch == 't' ? "try" 
+                      : (ch == 'f' ? "finally" 
+                                   : (ch == 'a' ? "autoreleasepool" : 0));
+        }
+        if (str) {
+          SourceLocation kwLoc = Tok.getLocation();
+          return ExprError(Diag(AtLoc, diag::err_unexpected_at) << 
+                             FixItHint::CreateReplacement(kwLoc, str));
+        }
+        else
+          return ExprError(Diag(AtLoc, diag::err_unexpected_at));
+      }
     }
   }
 }
diff --git a/test/FixIt/fixit-autoreleasepool.m b/test/FixIt/fixit-autoreleasepool.m
new file mode 100644 (file)
index 0000000..ba1ad13
--- /dev/null
@@ -0,0 +1,9 @@
+// RUN: %clang_cc1 -triple x86_64-apple-darwin10  -fdiagnostics-parseable-fixits -x objective-c %s 2>&1 | FileCheck %s
+// rdar://10723084
+
+void f0() {
+  @autorelease {
+  } 
+}
+
+// CHECK: {5:4-5:15}:"autoreleasepool"