NULL is a valid return value of mmap. Check against (void *) MAP_FAILED.

diff --git a/ext/standard/file.c b/ext/standard/file.c
index ae0b9ab5274ae727cdc5dad670be03d77baeb7b0..278282d721d95c360c1a26baa180445fb0d40037 100644 (file)
--- a/ext/standard/file.c
+++ b/ext/standard/file.c
@@ -1687,7 +1687,7 @@ PHPAPI int php_copy_file(char *src, char *dest)
                        goto cleanup;
                }
                srcfile = mmap(NULL, sbuf.st_size, PROT_READ, MAP_SHARED, fd_s, 0);
-               if (srcfile) {
+               if (srcfile != (void *) MAP_FAILED) {
                        write(fd_t, srcfile, sbuf.st_size);
                        ret = SUCCESS;
                        munmap(srcfile, sbuf.st_size);