]> granicus.if.org Git - python/commitdiff
Merge: #17443: Fix buffering in IMAP4_stream.
authorR David Murray <rdmurray@bitdance.com>
Tue, 19 Mar 2013 17:56:54 +0000 (13:56 -0400)
committerR David Murray <rdmurray@bitdance.com>
Tue, 19 Mar 2013 17:56:54 +0000 (13:56 -0400)
In Python2 Popen uses *FILE objects, which wind up buffering even though
subprocess defaults to no buffering.  In Python3, subprocess streams really
are unbuffered by default, but the imaplib code assumes read is buffered.  This
patch uses the default buffer size from the io module to get buffered streams
from Popen.

Much debugging work and patch by Diane Trout.

The imap protocol is too complicated to write a test for this simple
change with our current level of test infrastructure.

1  2 
Lib/imaplib.py
Misc/ACKS
Misc/NEWS

diff --cc Lib/imaplib.py
Simple merge
diff --cc Misc/ACKS
Simple merge
diff --cc Misc/NEWS
Simple merge