Don't write "if self.dict: self.dict.close()"; just write

"self.dict.close()" and ignore the exception.  The "if self.dict:"
part would be calculated through len(self.dict.keys()), which is very
expensive for a large dictionary...

diff --git a/Lib/shelve.py b/Lib/shelve.py
index 9b65a0911fa6bd376aca9a613af62008a78b9e5a..6bdc0305dd9e225dc6e896c6312c0fd23408fbb4 100644 (file)
--- a/Lib/shelve.py
+++ b/Lib/shelve.py
@@ -75,8 +75,7 @@ class Shelf:
        
        def close(self):
                try:
-                       if self.dict:
-                               self.dict.close()
+                    self.dict.close()
                except:
                        pass
                self.dict = 0