Fix for bug #12081

@ - Fix return value for a failed snmpset() - now returns false  (Rasmus)

diff --git a/ext/snmp/snmp.c b/ext/snmp/snmp.c
index 0403e30bbe62da28c13b9f7ac155268ae8cfce84..9998dff0a437bf5eab4c504930877c3b3b3a54f8 100644 (file)
--- a/ext/snmp/snmp.c
+++ b/ext/snmp/snmp.c
@@ -264,9 +264,17 @@ void php_snmp(INTERNAL_FUNCTION_PARAMETERS, int st) {
        if (st >= 2) {
                memmove((char *)name, (char *)root, rootlen * sizeof(oid));
                name_length = rootlen;
-               if (array_init(return_value) == FAILURE) {
-                       php_error(E_WARNING, "Cannot prepare result array");
-                       RETURN_FALSE;
+               switch(st) {
+                       case 2:
+                       case 3:
+                               if (array_init(return_value) == FAILURE) {
+                                       php_error(E_WARNING, "Cannot prepare result array");
+                                       RETURN_FALSE;
+                               }
+                               break;
+                       default:
+                               RETVAL_TRUE;
+                               break;
                }
        }