]> granicus.if.org Git - clang/commitdiff
When building a module, all headers of submodules can be used.
authorDaniel Jasper <djasper@google.com>
Fri, 13 Mar 2015 14:29:39 +0000 (14:29 +0000)
committerDaniel Jasper <djasper@google.com>
Fri, 13 Mar 2015 14:29:39 +0000 (14:29 +0000)
This extends r232159.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@232168 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Lex/ModuleMap.cpp
test/Modules/declare-use5.cpp [new file with mode: 0644]

index 6aefb03526658b7b46697eee858b117bde8436a6..b0195af70b64a1deaa1e34657f37f06d969aac6e 100644 (file)
@@ -265,7 +265,8 @@ void ModuleMap::diagnoseHeaderInclusion(Module *RequestingModule,
   if (Known != Headers.end()) {
     for (const KnownHeader &Header : Known->second) {
       // If 'File' is part of 'RequestingModule' we can definitely include it.
-      if (Header.getModule() == RequestingModule)
+      if (Header.getModule() &&
+          Header.getModule()->isSubModuleOf(RequestingModule))
         return;
 
       // Remember private headers for later printing of a diagnostic.
diff --git a/test/Modules/declare-use5.cpp b/test/Modules/declare-use5.cpp
new file mode 100644 (file)
index 0000000..b34be0f
--- /dev/null
@@ -0,0 +1,9 @@
+// RUN: rm -rf %t
+// RUN: %clang_cc1 -fmodule-maps -fmodules-cache-path=%t -fmodules-decluse -fmodule-name=XN -I %S/Inputs/declare-use %s -verify
+
+
+#include "sub.h"
+
+const int a = sub;
+
+// expected-no-diagnostics