t4209: use helper functions to test --grep

Also add tests for non-matching cases.

Signed-off-by: Rene Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/t/t4209-log-pickaxe.sh b/t/t4209-log-pickaxe.sh
index 919b371169ac6c1eb3010f7bafa2685c19109013..eaa14a057cf84f85e07023a341b7750c08af6a3c 100755 (executable)
--- a/t/t4209-log-pickaxe.sh
+++ b/t/t4209-log-pickaxe.sh
@@ -55,20 +55,10 @@ test_expect_success setup '
        git rev-parse --verify HEAD >expect_second
 '
 
-test_expect_success 'log --grep' '
-       git log --grep=initial --format=%H >actual &&
-       test_cmp expect_initial actual
-'
-
-test_expect_success 'log --grep --regexp-ignore-case' '
-       git log --regexp-ignore-case --grep=InItial --format=%H >actual &&
-       test_cmp expect_initial actual
-'
-
-test_expect_success 'log --grep -i' '
-       git log -i --grep=InItial --format=%H >actual &&
-       test_cmp expect_initial actual
-'
+test_log       expect_initial  --grep initial
+test_log       expect_nomatch  --grep InItial
+test_log_icase expect_initial  --grep InItial
+test_log_icase expect_nomatch  --grep initail
 
 test_expect_success 'log --author --regexp-ignore-case' '
        git log --regexp-ignore-case --author=person --format=%H >actual &&