]> granicus.if.org Git - python/commitdiff
Closes #21780: make the unicodedata module "ssize_t clean" for parsing parameters
authorVictor Stinner <victor.stinner@gmail.com>
Tue, 1 Jul 2014 14:45:52 +0000 (16:45 +0200)
committerVictor Stinner <victor.stinner@gmail.com>
Tue, 1 Jul 2014 14:45:52 +0000 (16:45 +0200)
Modules/unicodedata.c

index 3253db21f1b94098aa2e7f5d373b5851989b9d33..3979f65738df9f471f259672f3506836cfe6c44f 100644 (file)
@@ -13,6 +13,8 @@
 
    ------------------------------------------------------------------------ */
 
+#define PY_SSIZE_T_CLEAN
+
 #include "Python.h"
 #include "ucnhash.h"
 #include "structmember.h"
@@ -1271,12 +1273,16 @@ unicodedata_lookup(PyObject* self, PyObject* args)
     Py_UCS4 code;
 
     char* name;
-    int namelen;
+    Py_ssize_t namelen;
     unsigned int index;
     if (!PyArg_ParseTuple(args, "s#:lookup", &name, &namelen))
         return NULL;
+    if (namelen > INT_MAX) {
+        PyErr_SetString(PyExc_KeyError, "name too long");
+        return NULL;
+    }
 
-    if (!_getcode(self, name, namelen, &code, 1)) {
+    if (!_getcode(self, name, (int)namelen, &code, 1)) {
         PyErr_Format(PyExc_KeyError, "undefined character name '%s'", name);
         return NULL;
     }