fix: broken check on resend message

By boolifying check_all_msg(), it's return value was inverted without
fixing the callers.  This would prevent users resending messages, or
crash.

diff --git a/recvcmd.c b/recvcmd.c
index c1c0ce3551372ee0949f98feee32a9da61737a4a..8a49ea517d603a2ff00deed97c5015f33c3633a6 100644 (file)
--- a/recvcmd.c
+++ b/recvcmd.c
@@ -58,7 +58,7 @@ static bool check_msg(struct Body *b, bool err)
   return true;
 }
 
-static short check_all_msg(struct AttachCtx *actx, struct Body *cur, short err)
+static bool check_all_msg(struct AttachCtx *actx, struct Body *cur, short err)
 {
   if (cur && !check_msg(cur, err))
     return false;
@@ -128,7 +128,7 @@ void mutt_attach_bounce(FILE *fp, struct Header *hdr, struct AttachCtx *actx, st
   int ret = 0;
   int p = 0;
 
-  if (check_all_msg(actx, cur, 1) == -1)
+  if (!check_all_msg(actx, cur, 1))
     return;
 
   /* one or more messages? */
@@ -242,7 +242,7 @@ void mutt_attach_bounce(FILE *fp, struct Header *hdr, struct AttachCtx *actx, st
  */
 void mutt_attach_resend(FILE *fp, struct Header *hdr, struct AttachCtx *actx, struct Body *cur)
 {
-  if (check_all_msg(actx, cur, 1) == -1)
+  if (!check_all_msg(actx, cur, 1))
     return;
 
   if (cur)
@@ -658,7 +658,7 @@ void mutt_attach_forward(FILE *fp, struct Header *hdr, struct AttachCtx *actx,
 {
   short nattach;
 
-  if (check_all_msg(actx, cur, 0) == 0)
+  if (check_all_msg(actx, cur, 0))
     attach_forward_msgs(fp, hdr, actx, cur, flags);
   else
   {
@@ -811,7 +811,7 @@ void mutt_attach_reply(FILE *fp, struct Header *hdr, struct AttachCtx *actx,
     unset_option(OPT_NEWS_SEND);
 #endif
 
-  if (check_all_msg(actx, cur, false) == -1)
+  if (!check_all_msg(actx, cur, false))
   {
     nattach = count_tagged(actx);
     if ((parent = find_parent(actx, cur, nattach)) != NULL)