]> granicus.if.org Git - php/commitdiff
getVersion() is in wrong place, should there be a PEAR_Error
authorGreg Beaver <cellog@php.net>
Sat, 5 Nov 2005 17:59:02 +0000 (17:59 +0000)
committerGreg Beaver <cellog@php.net>
Sat, 5 Nov 2005 17:59:02 +0000 (17:59 +0000)
pear/install-pear.php

index ddce382c025a4bf19941fc7b4dc5d6580b3b1b8f..908d6d3ad016a511e9d3662f2055d7a6a725d91b 100644 (file)
@@ -115,11 +115,11 @@ $pkg = &new PEAR_PackageFile($config, $debug);
 
 foreach ($install_files as $package => $instfile) {
     $info = &$pkg->fromAnyFile($instfile, PEAR_VALIDATE_INSTALLING);
-    $new_ver = $info->getVersion();
     if (PEAR::isError($info)) {
         $ui->outputData(sprintf("[PEAR] %s: %s", $package, $info->getMessage()));
         continue;
     }
+    $new_ver = $info->getVersion();
     $downloaderpackage = &new PEAR_Downloader_Package($installer);
     $err = $downloaderpackage->initialize($instfile);
     if (PEAR::isError($err)) {