idness not valid for attribute declarations

diff --git a/ext/dom/element.c b/ext/dom/element.c
index cd582ee0ab84b05fb0dc8c668e009fd364a1bf29..df95e877b0047e26b2b6e19a68e82d6e91e7e77f 100644 (file)
--- a/ext/dom/element.c
+++ b/ext/dom/element.c
@@ -954,7 +954,7 @@ PHP_FUNCTION(dom_element_set_id_attribute)
        }
 
        attrp = xmlHasNsProp(nodep, name, NULL);
-       if (attrp == NULL) {
+       if (attrp == NULL || attrp->type == XML_ATTRIBUTE_DECL) {
                php_dom_throw_error(NOT_FOUND_ERR, dom_get_strict_error(intern->document) TSRMLS_CC);
        } else {
                php_set_attribute_id(attrp, is_id);
@@ -991,7 +991,7 @@ PHP_FUNCTION(dom_element_set_id_attribute_ns)
        }
 
        attrp = xmlHasNsProp(elemp, name, uri);
-       if (attrp == NULL) {
+       if (attrp == NULL || attrp->type == XML_ATTRIBUTE_DECL) {
                php_dom_throw_error(NOT_FOUND_ERR, dom_get_strict_error(intern->document) TSRMLS_CC);
        } else {
                php_set_attribute_id(attrp, is_id);