]> granicus.if.org Git - llvm/commitdiff
AMDGPU: Fix folding reg_sequence into copy to phys reg
authorMatt Arsenault <Matthew.Arsenault@amd.com>
Tue, 11 Apr 2017 22:29:19 +0000 (22:29 +0000)
committerMatt Arsenault <Matthew.Arsenault@amd.com>
Tue, 11 Apr 2017 22:29:19 +0000 (22:29 +0000)
This was producing an illegal reg_sequence defining
a physical register with virtual register inputs.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@299997 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Target/AMDGPU/SIFixSGPRCopies.cpp
test/CodeGen/AMDGPU/inline-asm.ll

index 43cb15f502cd00c8aea5933eae800939588789c9..34cd6f704a12f51e0fb00bb3c8899c6784ce2eff 100644 (file)
@@ -198,6 +198,10 @@ static bool foldVGPRCopyIntoRegSequence(MachineInstr &MI,
   if (!CopyUse.isCopy())
     return false;
 
+  // It is illegal to have vreg inputs to a physreg defining reg_sequence.
+  if (TargetRegisterInfo::isPhysicalRegister(CopyUse.getOperand(0).getReg()))
+    return false;
+
   const TargetRegisterClass *SrcRC, *DstRC;
   std::tie(SrcRC, DstRC) = getCopyRegClasses(CopyUse, *TRI, MRI);
 
index 85eb163383e143ec4f451bc9b41f165ce471d356..5d49b11f0d416b39374e75c8e158bfbdae20c608 100644 (file)
@@ -183,3 +183,16 @@ entry:
   ", ""()
   ret void
 }
+
+; FIXME: Should not have intermediate sgprs
+; CHECK-LABEL: {{^}}i64_imm_input_phys_vgpr:
+; CHECK: s_mov_b32 s1, 0
+; CHECK: s_mov_b32 s0, 0x1e240
+; CHECK: v_mov_b32_e32 v0, s0
+; CHECK: v_mov_b32_e32 v1, s1
+; CHECK: use v[0:1]
+define void @i64_imm_input_phys_vgpr() {
+entry:
+  call void asm sideeffect "; use $0 ", "{VGPR0_VGPR1}"(i64 123456)
+  ret void
+}