]> granicus.if.org Git - python/commitdiff
bpo-38239: Fix test_gdb for Link Time Optimization (LTO) (GH-16422)
authorVictor Stinner <vstinner@redhat.com>
Thu, 26 Sep 2019 14:54:13 +0000 (16:54 +0200)
committerGitHub <noreply@github.com>
Thu, 26 Sep 2019 14:54:13 +0000 (16:54 +0200)
Lib/test/test_gdb.py
Misc/NEWS.d/next/Tests/2019-09-26-15-48-36.bpo-38239.MfoVzY.rst [new file with mode: 0644]

index e515d0d3fb513e9ce7100b4bdb942a1d4ccd9dd1..eb94f92961f6f97622c6f359bbbc0072ecc5cb0b 100644 (file)
@@ -255,8 +255,15 @@ class DebuggerTests(unittest.TestCase):
         # gdb can insert additional '\n' and space characters in various places
         # in its output, depending on the width of the terminal it's connected
         # to (using its "wrap_here" function)
-        m = re.match(r'.*#0\s+builtin_id\s+\(self\=.*,\s+v=\s*(.*?)?\)\s+at\s+\S*Python/bltinmodule.c.*',
-                     gdb_output, re.DOTALL)
+        m = re.search(
+            # Match '#0 builtin_id(self=..., v=...)'
+            r'#0\s+builtin_id\s+\(self\=.*,\s+v=\s*(.*?)?\)'
+            # Match ' at Python/bltinmodule.c'.
+            # bpo-38239: builtin_id() is defined in Python/bltinmodule.c,
+            # but accept any "Directory\file.c" to support Link Time
+            # Optimization (LTO).
+            r'\s+at\s+\S*[A-Za-z]+/[A-Za-z0-9_-]+\.c',
+            gdb_output, re.DOTALL)
         if not m:
             self.fail('Unexpected gdb output: %r\n%s' % (gdb_output, gdb_output))
         return m.group(1), gdb_output
diff --git a/Misc/NEWS.d/next/Tests/2019-09-26-15-48-36.bpo-38239.MfoVzY.rst b/Misc/NEWS.d/next/Tests/2019-09-26-15-48-36.bpo-38239.MfoVzY.rst
new file mode 100644 (file)
index 0000000..f79da29
--- /dev/null
@@ -0,0 +1 @@
+Fix test_gdb for Link Time Optimization (LTO) builds.