]> granicus.if.org Git - php/commitdiff
MFB:fix memleak in sxe_prop_dim_read()
authorNuno Lopes <nlopess@php.net>
Sun, 24 Jun 2007 11:43:34 +0000 (11:43 +0000)
committerNuno Lopes <nlopess@php.net>
Sun, 24 Jun 2007 11:43:34 +0000 (11:43 +0000)
ext/simplexml/simplexml.c

index d4b773560af76878c89628ac2bf07d6df392a5d6..f87c3c8b6a8f5eea423ec4ca2877a13f0ba052b6 100644 (file)
@@ -271,9 +271,6 @@ static zval * sxe_prop_dim_read(zval *object, zval *member, zend_bool elements,
                name = Z_STRVAL_P(member);
        }
 
-       MAKE_STD_ZVAL(return_value);
-       ZVAL_NULL(return_value);
-
        GET_NODE(sxe, node);
 
        if (sxe->iter.type == SXE_ITER_ATTRLIST) {
@@ -294,6 +291,9 @@ static zval * sxe_prop_dim_read(zval *object, zval *member, zend_bool elements,
                }
        }
 
+       MAKE_STD_ZVAL(return_value);
+       ZVAL_NULL(return_value);
+
        if (node) {
                if (attribs) {
                        if (Z_TYPE_P(member) != IS_LONG || sxe->iter.type == SXE_ITER_ATTRLIST) {