]> granicus.if.org Git - shadow/commitdiff
snprintf() always terminates output with \0
authorTomas Mraz <tmraz@fedoraproject.org>
Tue, 15 Nov 2016 15:05:44 +0000 (16:05 +0100)
committerTomas Mraz <tmraz@fedoraproject.org>
Tue, 15 Nov 2016 15:05:44 +0000 (16:05 +0100)
lib/groupio.c

index 3ad4736bbf0cbed57b0806fc1bc4aefbb51fd68c..ae2302b564e2ccea2c69fa71cdb39f52069a45ff 100644 (file)
@@ -338,8 +338,7 @@ static /*@null@*/struct commonio_entry *merge_group_entries (
                errno = ENOMEM;
                return NULL;
        }
-       snprintf(new_line, new_line_len, "%s\n%s", gr1->line, gr2->line);
-       new_line[new_line_len] = '\0';
+       snprintf(new_line, new_line_len + 1, "%s\n%s", gr1->line, gr2->line);
 
        /* Concatenate the 2 list of members */
        for (i=0; NULL != gptr1->gr_mem[i]; i++);