Call set_rel_pathlist_hook before generate_gather_paths, not after.

The previous ordering of these steps satisfied the nominal requirement
that set_rel_pathlist_hook could editorialize on the whole set of Paths
constructed for a base relation.  In practice, though, trying to change
the set of partial paths was impossible.  Adding one didn't work because
(a) it was too late to be included in Gather paths made by the core code,
and (b) calling add_partial_path after generate_gather_paths is unsafe,
because it might try to delete a path it thinks is dominated, but that
is already embedded in some Gather path(s).  Nor could the hook safely
remove partial paths, for the same reason that they might already be
embedded in Gathers.

Better to call extensions first, let them add partial paths as desired,
and then gather.  In v11 and up, we already doubled down on that ordering
by postponing gathering even further for single-relation queries; so even
if the hook wished to editorialize on Gather path construction, it could
not.

Report and patch by KaiGai Kohei.  Back-patch to 9.6 where Gather paths
were added.

Discussion: https://postgr.es/m/CAOP8fzahwpKJRTVVTqo2AE=mDTz_efVzV6Get_0=U3SO+-ha1A@mail.gmail.com

diff --git a/doc/src/sgml/custom-scan.sgml b/doc/src/sgml/custom-scan.sgml
index 24631f5f4045d010015ade5befb27b622083236d..ab9b055d9a9e1edbc15455d63ea204be78a5774d 100644 (file)
--- a/doc/src/sgml/custom-scan.sgml
+++ b/doc/src/sgml/custom-scan.sgml
@@ -37,8 +37,9 @@
   <para>
     A custom scan provider will typically add paths for a base relation by
     setting the following hook, which is called after the core code has
-    generated what it believes to be the complete and correct set of access
-    paths for the relation.
+    generated all the access paths it can for the relation (except for
+    Gather paths, which are made after this call so that they can use
+    partial paths added by the hook):
 <programlisting>
 typedef void (*set_rel_pathlist_hook_type) (PlannerInfo *root,
                                             RelOptInfo *rel,

diff --git a/src/backend/optimizer/path/allpaths.c b/src/backend/optimizer/path/allpaths.c
index 55b871c02c904ec20b71bd502a441a1ffbc8fa19..0debac75c6261939ea3b184838ffbd73aba89f68 100644 (file)
--- a/src/backend/optimizer/path/allpaths.c
+++ b/src/backend/optimizer/path/allpaths.c
@@ -529,9 +529,20 @@ set_rel_pathlist(PlannerInfo *root, RelOptInfo *rel,
                }
        }
 
+       /*
+        * Allow a plugin to editorialize on the set of Paths for this base
+        * relation.  It could add new paths (such as CustomPaths) by calling
+        * add_path(), or add_partial_path() if parallel aware.  It could also
+        * delete or modify paths added by the core code.
+        */
+       if (set_rel_pathlist_hook)
+               (*set_rel_pathlist_hook) (root, rel, rti, rte);
+
        /*
         * If this is a baserel, we should normally consider gathering any partial
-        * paths we may have created for it.
+        * paths we may have created for it.  We have to do this after calling the
+        * set_rel_pathlist_hook, else it cannot add partial paths to be included
+        * here.
         *
         * However, if this is an inheritance child, skip it.  Otherwise, we could
         * end up with a very large number of gather nodes, each trying to grab
@@ -539,21 +550,13 @@ set_rel_pathlist(PlannerInfo *root, RelOptInfo *rel,
         * paths for the parent appendrel.
         *
         * Also, if this is the topmost scan/join rel (that is, the only baserel),
-        * we postpone this until the final scan/join targelist is available (see
-        * grouping_planner).
+        * we postpone gathering until the final scan/join targetlist is available
+        * (see grouping_planner).
         */
        if (rel->reloptkind == RELOPT_BASEREL &&
                bms_membership(root->all_baserels) != BMS_SINGLETON)
                generate_gather_paths(root, rel, false);
 
-       /*
-        * Allow a plugin to editorialize on the set of Paths for this base
-        * relation.  It could add new paths (such as CustomPaths) by calling
-        * add_path(), or delete or modify paths added by the core code.
-        */
-       if (set_rel_pathlist_hook)
-               (*set_rel_pathlist_hook) (root, rel, rti, rte);
-
        /* Now find the cheapest of the paths for this rel */
        set_cheapest(rel);