]> granicus.if.org Git - libvpx/commitdiff
Fix UBSAN/IOC errors
authorYaowu Xu <yaowu@google.com>
Tue, 31 May 2016 23:54:58 +0000 (16:54 -0700)
committerYaowu Xu <yaowu@google.com>
Wed, 1 Jun 2016 16:01:18 +0000 (16:01 +0000)
1. test/dct16x16_test.cc
2. test/dct32x32_test.cc
3. test/fdct8x8_test.cc

BUG=webm:1225

Change-Id: I9c9315fbd65ddb3b44f688e01ba265fd22192198

test/dct16x16_test.cc
test/dct32x32_test.cc
test/fdct8x8_test.cc

index c4dfaf34591c4991e4dbf3955969943c0b3ff566..ddaf9395b2ba234bcee61e2ea857fb842dddacfd 100644 (file)
@@ -373,10 +373,10 @@ class Trans16x16TestBase {
 
       for (int j = 0; j < kNumCoeffs; ++j) {
 #if CONFIG_VP9_HIGHBITDEPTH
-        const uint32_t diff =
+        const int32_t diff =
             bit_depth_ == VPX_BITS_8 ?  dst[j] - src[j] : dst16[j] - src16[j];
 #else
-        const uint32_t diff = dst[j] - src[j];
+        const int32_t diff = dst[j] - src[j];
 #endif
         const uint32_t error = diff * diff;
         if (max_error < error)
index 1cbac5c636ce28158e63c918d3f6bea3e279e80d..16d88255e5b241d5886da720884f83aa18e7df2c 100644 (file)
@@ -154,10 +154,10 @@ TEST_P(Trans32x32Test, AccuracyCheck) {
 
     for (int j = 0; j < kNumCoeffs; ++j) {
 #if CONFIG_VP9_HIGHBITDEPTH
-      const uint32_t diff =
+      const int32_t diff =
           bit_depth_ == VPX_BITS_8 ? dst[j] - src[j] : dst16[j] - src16[j];
 #else
-      const uint32_t diff = dst[j] - src[j];
+      const int32_t diff = dst[j] - src[j];
 #endif
       const uint32_t error = diff * diff;
       if (max_error < error)
index edf46821695004d2a227cf8169b3177801e92635..0c081ee1f0ff5bdf4cd05b67b1b0d416ffa7c289 100644 (file)
@@ -458,7 +458,7 @@ class FwdTrans8x8TestBase {
         coeff_r[j] = static_cast<tran_low_t>(round(out_r[j]));
 
       for (int j = 0; j < kNumCoeffs; ++j) {
-        const uint32_t diff = coeff[j] - coeff_r[j];
+        const int32_t diff = coeff[j] - coeff_r[j];
         const uint32_t error = diff * diff;
         EXPECT_GE(9u << 2 * (bit_depth_ - 8), error)
             << "Error: 8x8 DCT has error " << error