]> granicus.if.org Git - clang/commitdiff
Remove last FIXME for block literal codegen that I know about and turn
authorMike Stump <mrs@apple.com>
Sat, 7 Mar 2009 06:16:52 +0000 (06:16 +0000)
committerMike Stump <mrs@apple.com>
Sat, 7 Mar 2009 06:16:52 +0000 (06:16 +0000)
on all the new code by default.  There is still plenty of testing to
do and issues I'm sure need resolving.  Let me know if you find
anything.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@66323 91177308-0d34-0410-b5e6-96231b3b80d8

lib/CodeGen/CGBlocks.cpp

index 4e4698273fc494c22b19444da96eda80fa7370ff..9e3c4519cfff5fe31b2c227fc62df3ae618987bd 100644 (file)
@@ -31,7 +31,7 @@ Enable__block("f__block",
                              "even though the code isn't done yet"),
               llvm::cl::ValueDisallowed, llvm::cl::AllowInverse,
               llvm::cl::ZeroOrMore,
-              llvm::cl::init(false));
+              llvm::cl::init(true));
 
 llvm::Constant *CodeGenFunction::
 BuildDescriptorBlockDecl(uint64_t Size, const llvm::StructType* Ty,
@@ -479,7 +479,6 @@ llvm::Value *CodeGenFunction::GetAddrOfBlockDecl(const BlockDeclRefExpr *E) {
   const llvm::Type *Ty;
   Ty = CGM.getTypes().ConvertType(E->getDecl()->getType());
 
-  // FIXME: add support for copy/dispose helpers.
   if (!Enable__block && E->isByRef())
     ErrorUnsupported(E, "__block variable in block literal");
   else if (!Enable__block && E->getType()->isBlockPointerType())