]> granicus.if.org Git - graphviz/commitdiff
sccmap.c: use another unsigned type to squash -Wconversion warnings
authorMatthew Fernandez <matthew.fernandez@gmail.com>
Sat, 13 Nov 2021 02:53:14 +0000 (18:53 -0800)
committerMatthew Fernandez <matthew.fernandez@gmail.com>
Fri, 19 Nov 2021 01:52:24 +0000 (17:52 -0800)
The `val` member of `Agnodeinfo_t` is unsigned and all uses of this function
store the return value in an unsigned. So it seems this function always should
have been declared as returning an unsigned.

cmd/tools/sccmap.c

index 030eb83ca715f427d8bcb08f5ff2dabaad08b617..20808c7cdcd97be304044a2d4bcf5961fce4dd5f 100644 (file)
@@ -71,8 +71,7 @@ static void setscc(Agnode_t * n, Agraph_t * scc)
 static unsigned getval(Agnode_t *n) {
     return (((Agnodeinfo_t *) (n->base.data))->val);
 }
-static void setval(Agnode_t * n, int v)
-{
+static void setval(Agnode_t *n, unsigned v) {
     ((Agnodeinfo_t *) (n->base.data))->val = v;
 }
 #endif