]> granicus.if.org Git - curl/commitdiff
ares::Curl_resolver_cancel: skip checking for NULL conn
authorDaniel Stenberg <daniel@haxx.se>
Tue, 7 Oct 2014 11:33:43 +0000 (13:33 +0200)
committerDaniel Stenberg <daniel@haxx.se>
Tue, 7 Oct 2014 11:33:43 +0000 (13:33 +0200)
Coverity CID 1243581. 'conn' will never be NULL here, and if it would be
the subsequent statement would dereference it!

lib/asyn-ares.c

index 01a9c9b50e80dde7836b38d89c755ae6684f6018..48b2376ba09d3dbbde9b3bdc4de340158a87a4d6 100644 (file)
@@ -178,7 +178,7 @@ static void destroy_async_data (struct Curl_async *async);
  */
 void Curl_resolver_cancel(struct connectdata *conn)
 {
-  if(conn && conn->data && conn->data->state.resolver)
+  if(conn->data && conn->data->state.resolver)
     ares_cancel((ares_channel)conn->data->state.resolver);
   destroy_async_data(&conn->async);
 }