]> granicus.if.org Git - php/commitdiff
Throw Error exception in DOM_GET_OBJ
authorNikita Popov <nikita.ppv@gmail.com>
Thu, 13 Aug 2020 11:15:38 +0000 (13:15 +0200)
committerNikita Popov <nikita.ppv@gmail.com>
Thu, 13 Aug 2020 12:43:40 +0000 (14:43 +0200)
Per general convention for handling of uninitialized objects.

ext/dom/php_dom.h

index 7a0a5e7d72e5f991e05dde8414f43b396dfe81a8..285980b64644b97381f213d2b77dc084e01efb5f 100644 (file)
@@ -140,8 +140,8 @@ entry = zend_register_internal_class_ex(&ce, parent_ce);
 #define DOM_GET_OBJ(__ptr, __id, __prtype, __intern) { \
        __intern = Z_DOMOBJ_P(__id); \
        if (__intern->ptr == NULL || !(__ptr = (__prtype)((php_libxml_node_ptr *)__intern->ptr)->node)) { \
-               php_error_docref(NULL, E_WARNING, "Couldn't fetch %s", ZSTR_VAL(__intern->std.ce->name));\
-               RETURN_NULL();\
+               zend_throw_error(NULL, "Couldn't fetch %s", ZSTR_VAL(__intern->std.ce->name));\
+               RETURN_THROWS();\
        } \
 }