Fix potential coredump on bad locale value in pg_upgrade.

Thinko in error report (and a typo in the message text, too).  We're
failing anyway, but it would be good to print something useful first.
Noted while reviewing a patch to make pg_upgrade's locale code laxer.

diff --git a/contrib/pg_upgrade/check.c b/contrib/pg_upgrade/check.c
index e9e9a4fe339a50bb896c7edf0e19e9d36bcc42e9..32b9bb998ae91f5b9c18452f5b64026545707872 100644 (file)
--- a/contrib/pg_upgrade/check.c
+++ b/contrib/pg_upgrade/check.c
@@ -979,7 +979,7 @@ get_canonical_locale_name(int category, const char *locale)
        res = setlocale(category, locale);
 
        if (!res)
-        pg_log(PG_FATAL, "failed to get system local name for \"%s\"\n", res);
+        pg_log(PG_FATAL, "failed to get system locale name for \"%s\"\n", locale);
 
        res = pg_strdup(res);